Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hybrid search vector per target #1160

Merged
merged 6 commits into from
Jul 5, 2024
Merged

Hybrid search vector per target #1160

merged 6 commits into from
Jul 5, 2024

Conversation

dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented Jul 4, 2024 •
edited
Loading

Adds support for

    objs = collection.query.hybrid(
        query=None,
        vector=wvc.query.HybridVector.near_vector({"first": [1, 0], "second": [1, 0, 0]}, distance=0.1),
        target_vector=["first", "second"],
    ).objects

and

    objs = collection.query.hybrid(
        query=None,
        vector={"first": [1, 0], "second": [1, 0, 0]},
        target_vector=["first", "second"],
    ).objects

It also adds the filename of the test to the collection name - I thought I had duplicate test names and added it. Wasn't the issue in the end but I think it doesn't hurt

@dirkkul dirkkul requested a review from tsmith023 July 4, 2024 10:34
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.31707% with 26 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev/1.26@9f1f3af). Learn more about missing BASE report.

Files Patch % Lines
integration/test_collection_hybrid.py 86.27% 21 Missing ⚠️
weaviate/collections/grpc/query.py 89.36% 5 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             dev/1.26    #1160   +/-   ##
===========================================
  Coverage            ?   94.50%           
===========================================
  Files               ?      198           
  Lines               ?    19641           
  Branches            ?        0           
===========================================
  Hits                ?    18562           
  Misses              ?     1079           
  Partials            ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dirkkul dirkkul merged commit 6d6e80c into dev/1.26 Jul 5, 2024
45 checks passed
@dirkkul dirkkul deleted the hybrid_vector_per_target branch July 5, 2024 09:44
@gokturkDev
Copy link

Hi is this live and does this signal the beginning of multi-vector search for weaviate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmith023 tsmith023 tsmith023 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dirkkul @codecov-commenter @gokturkDev @tsmith023